Add a test not to interpret strings as lists #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s lists. In Python, for example, strings are sequence types that share many of the same properties as lists and other iterator types: http://docs.python.org/library/stdtypes.html#sequence-types-str-unicode-list-tuple-bytearray-buffer-xrange A test for this does not yet exist in the spec (incidental or not).
|
In Ruby 1.8.x, strings are Enumerable by line, so treating |
cjerdonek
added a commit
to cjerdonek/mustache-spec
that referenced
this pull request
May 3, 2012
…development See issue mustache#43: mustache#43
|
Nowadays, the following test is included in the spec, which subtly implies that a string should not be iterated as a list: Lines 68 to 75 in 5d3b58e Hence, the proposed addition is not needed. Closing, discussion still welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python, for example (as in many other languages undoubtedly), strings are sequence types that share many of the same properties as lists and other iterator types:
http://docs.python.org/library/stdtypes.html#sequence-types-str-unicode-list-tuple-bytearray-buffer-xrange
It would be good to add a test for this. One does not seem to exist yet in the spec (incidental or not).